ports/65043: [patch] net/rsync: problems in client name lookup code

Wayne Davison wayned at samba.org
Fri Apr 2 00:40:47 GMT 2004

On Thu, Apr 01, 2004 at 06:38:04PM -0500, Alex Vasylenko wrote:
> I think your second patch is superfluous, as getpeername returns a 
> correctly formatted sockaddr (with _len set, if it's there), so it 
> should be sufficient to simply drop the "ss.ss_len = ss_len;" line from 
> my original patch

Cool.  I thought the length should be OK after that call, but I was
trying to figure out how this part of your bug report figured into
your patch:

> 	- fails to set ss_len member of struct sockaddr_storage, which when
> 	  passed to getnameinfo causes the latter to fail;

If there's a problem, let me know.


More information about the rsync mailing list