[patch] replace dir with file error

jw schultz jw at pegasys.ws
Thu Sep 4 15:50:18 EST 2003

On Tue, Sep 02, 2003 at 04:43:07PM -0700, jw schultz wrote:
> Hit the "not a regular file (recv_files)" error last night
> having replaced a directory with a file.
> The really dumb part is that this was hit doing a link-dest
> on an empty destination so the robust_unlink would have
> presented no problem anyway.
> I can see no reason why non-directory special files should
> have any problem being replaced so i've changed that logic too.
> The new code simply treats old non-directory special files
> as though they were non-existent and the same for
> directories if they aren't in the destination (coming from
> link-dest or compare-dest.
> As the new comment in the patch indicates, we wouldn't have
> this problem at all if robust_unlink could cope with
> non-empty directories.
> Barring comments or objections i'll commit this soon.


More information about the rsync mailing list