2.5.6: a number of minor issues

jw schultz jw at pegasys.ws
Thu Oct 9 02:48:45 EST 2003

On Wed, Oct 08, 2003 at 06:03:55AM -0400, der Mouse wrote:
> I just picked up rsync 2.5.6 and installed it.  I haven't actually
> _used_ it for anything yet; this is entirely about a handful of minor
> issues I noticed while building it.  You may care or you may not; for
> simplicity of language (to avoid many repeated "in case you care" and
> such), the text below is written assuming you care about them all.
> On a (32-bit) SPARC system, I noticed:
> The code prints size_t values with %d.  This is always wrong with
> respect to signedness and often wrong with respect to size.
> Several routines have unused arguments with, in most cases, no obvious
> reason for their presence.
> Here are patches to fix the printf mistakes and shut the compiler
> warnings up about the unused arguments.

Thanks but 2.5.6 was released many months ago and there have
been numerous code changes (including compiler warning
cleanups) since.

More information about the rsync mailing list