Unhelpful error message when matching hosts in access list [PATCH]

[John Van Essen]

On Sat, 5 Jul 2003, Thorild Selen <thorild at Update.UU.SE> wrote:

>Greetings,
>
>As previously reported by me to the Debian bug tracking system:
>
>----------------------------------------------------------------------
>
>An access list in rsyncd.conf may contain hostnames as well as
>addresses. It may contain several patterns to match against.
>address_match (in access.c) does this by trying to match hostname and
>address against each of the patterns until a match is found or there
>are no more patterns.
>
>1. For each failed hostname match, an address (non-hostname) match is
>  also attempted. If the pattern isn't a valid address (maybe because
>  it is a hostname that didn't match the pattern) the less helpful
>  error message "malformed address <foo>" is written to the log for
>  every failed match. If hostname "baz" is matched against the
>  pattern list "foo, bar, baz" this will give two confusing error
>  messages "malformed address foo" "malformed address bar" in the
>  log.
>
>  Suggestion: If something looks like a hostname and not like an
>  address (by some clever criterion), then this match either should
>  not be done, or the confusing error message should not be printed.

I had submitted a similar bug report and small patch on April 10:

  http://lists.samba.org/pipermail/rsync/2003-April/010404.html

There were no followups to it at the time.
-- 
        John Van Essen  <vanes002 at umn.edu>