[PATCH] open O_TEXT and O_BINARY for cygwin/windows

[Dave Dykstra]

On Tue, Jan 28, 2003 at 01:26:32PM -0000, Max Bowsher wrote:
> Dave Dykstra wrote:
> > I give up.  The msleep(100) consistently causes hangs of the
> > unsafe-links test on my friend's cygwin Windows 2000 machine.  I
> > suspect it's also the reason why the build.samba.org cygwin machine
> > hasn't reported a result in the last 9 hours.  I'm taking it back out
> > and washing my hands of the cygwin rsync port, I'm fed up.
> 
> You've been most considerate in actively seeking out and merging Cygwin
> patches for this release. Alas, it backfired in merging the msleep thing. I
> definitely agree with it not being in the upstream sources. Making a race
> condition harder to hit, with a simple delay, is obviously not a fix. You
> may be pleased to know that the SHUTDOWN_ALL_SOCKETS change has eliminated
> "Connection reset by peer" messages when running the testsuite.

Well it's good to know that one of the cygwin changes did some good.

> It may be that the hang has just vanished. If it hasn't, it's probably a bug
> in Cygwin, not rsync. Hopefully we'll get a nice bugreport, and it can be
> traced and squashed.

Hopefully.

- Dave