[PATCH] open O_TEXT and O_BINARY for cygwin/windows

[Dave Dykstra]

On Mon, Jan 27, 2003 at 04:45:25PM -0000, Max Bowsher wrote:
> Dave Dykstra wrote:
> > On Mon, Jan 27, 2003 at 10:46:16AM +0100, Lapo Luchini wrote:
> >> I can test that before releasing cygwin's 2.5.6-1 package,
> >> unfortunately I have almost *no* free time until after friday
> >> (university test on thursday ^_^)
> >> Anyway Max is also right, local issues can be resolved locally with
> >> much speed, even if "in the long run" it's of course better to put
> >> them in rsync cvs too.
> >
> > I'm reluctant to rely on cygwin-stream-specific patches because I know
> > that other people compile it from source too.  Probably the msleep
> > should be put in for Cygwin only with an ifdef though, or the waiting
> > of the child removed altogether on Cygwin only.
> 
> Does it not make sense that anyone wishing to compile their own rsync for
> Cygwin should start by looking at the Cygwin package? (Which, btw, includes
> the clean rsync source, and patchfiles, so it is easy to see what is being
> done to rsync specially for Cygwin).

In my case I used to use the same source code to compile on many different
platforms and no, I wouldn't look at the Cygwin package first to compile
on Cygwin.


> The waiting for the child is presumably there for a reason. If is removed
> for Cygwin, it should probably be removed for all platforms. If there is an
> argument against that, then it applies equally to Cygwin as to any other
> platforms.

Perhaps the waiting in the child was put in for specific problems on
some platforms.


> >> BTW: I wonder if the sleepms(30) is still needed, it's quite a bit of
> >> time that my "build.samba.org" hourly cron doesn't produce a "hanged
> >> rsync"... (must check that too)
> >
> > I know that some people still experience it, and I don't think
> > anything has changed in that area since the time that the
> > person who experienced the hang discovered the hack.
> 
> Cygwin has gone through many minor versions since then. I suggest releasing
> an rsync without the hack, but with a command line option to turn it on.
> That way, we get to see for certain whether the problem still exists, and
> there is an easy workaround available if it does.

So many people have complained about Cygwin hangs that I'm inclined to
leave the msleep(100) in on this release by default, but only on Cygwin.
When the problem is shown to be fixed on Cygwin, it can be taken back
out.

- Dave