[PATCH] open O_TEXT and O_BINARY for cygwin/windows

Ville Herva vherva at niksula.hut.fi
Sat Jan 25 08:58:01 EST 2003

On Fri, Jan 24, 2003 at 05:09:43PM -0600, you [Dave Dykstra] wrote:
> I think I'll go ahead and put in your patch with the modification of using
> O_TEXT_STR as you suggest.  


> I think the risk is low.  

I think so, too.

> I had been concerned that perhaps older CPPs might not be able to handle
> that syntax, but I see other places in the rsync code that are depending
> on it so I think it's OK.

I think it is standard C, but OTOH looking at for example
reminds that not all ancient C preprocessors are compliant. But, with such
ancient beast, I think a lot of other things would break, too.

-- v --

v at iki.fi

More information about the rsync mailing list