[PATCH] open O_TEXT and O_BINARY for cygwin/windows

Max Bowsher maxb at ukf.net
Fri Jan 24 13:30:01 EST 2003


Ville Herva wrote:
> On Thu, Jan 23, 2003 at 01:55:40PM -0600, you [Dave Dykstra] wrote:
>> Why did you skip the fopen in log.c, which appends to the log file?
>
> I thought about that for a while. My reasoning was that the log file
> is probably read with unix/cygwin tools anyway - if not, the
> administrator is free to mount the filesystem binary or ascii. So I
> didn't want to enforce CR/LF on anyone.

Yes, please don't write in explicit text mode. Keeping the flexibility here
is good.


Max.




More information about the rsync mailing list