unsafe_symlink change (Re: CVS update: rsync)

Dave Dykstra dwd at drdykstra.us
Thu Jan 16 20:35:00 EST 2003


The patch from 2-1/2 years ago for changing copy-unsafe-links to follow
unsafe links on the destination side also included essentially this patch.
When I looked at it, however, I asked why in the world is unsafe_symlink()
doing strdup() in the first place.  I think you could get rid of the
calls to strdup() and the new local variables and possibly do a couple
casts inside the function instead.

- Dave


On Wed, Jan 15, 2003 at 12:49:44PM -0500, wayned at samba.org wrote to rsync-cvs:
> Re: CVS update: rsync
> 
> Date:	Wed Jan 15 17:49:44 2003
> Author:	wayned
> 
> Update of /data/cvs/rsync
> In directory dp.samba.org:/tmp/cvs-serv3194
> 
> Modified Files:
> 	proto.h util.c 
> Log Message:
> Make unsafe_symlink() take const args so that we don't get any
> compiler warnings when calling it with a const char *.
> 
> 
> Revisions:
> proto.h		1.150 => 1.151
> 	http://www.samba.org/cgi-bin/cvsweb/rsync/proto.h?r1=1.150&r2=1.151
> util.c		1.117 => 1.118
> 	http://www.samba.org/cgi-bin/cvsweb/rsync/util.c?r1=1.117&r2=1.118
> _______________________________________________
> rsync-cvs mailing list
> rsync-cvs at lists.samba.org
> http://lists.samba.org/mailman/listinfo/rsync-cvs



More information about the rsync mailing list