Inadequate error checking in rsync 2.5.5

jw schultz jw at pegasys.ws
Sat Aug 16 08:04:10 EST 2003


On Fri, Aug 15, 2003 at 02:04:50PM -0700, David Norwood wrote:
> > I've had a chance to think on it.  Attached is a patch that
> > allows unmap_file() to report the first read error that
> > map_ptr found.  The behaviour is the same.  I doubt this will
> > apply against anything but CVS HEAD as of now.
> >
> > This should probably use FERROR instead of FINFO so that a
> > partial transfer is reported.
> >
> > Any thoughts guys?
> 
> Okay, with this patch I now get error messages, but it still creates null
> filled output files.  I guess that is what you meant by "the behavior is the
> same".

That is correct.  At the point in which we detect the
problem there isn't anything we can do to produce
good files.  The most i can see our being able to do is to
warn you that it has happened.

-- 
________________________________________________________________
	J.W. Schultz            Pegasystems Technologies
	email address:		jw at pegasys.ws

		Remember Cernan and Schmitt



More information about the rsync mailing list