Should --progress implicitly assert -v?

[jw schultz]

On Tue, Aug 05, 2003 at 11:11:25PM -0700, Wayne Davison wrote:
> On Tue, Aug 05, 2003 at 12:25:51PM -0400, Toby Betts wrote:
> > -P or --progress without -v is, in a sense, gibberish.
> 
> Yeah, that seems logical to me.  Your patch is overly complex, but I'd
> be willing to check in something that does the same thing as long as no
> one has any objections to this.

I concur on all points.

Option dependencies aught to be enforced or enablement
implied.  We automatically enable --delete if
--delete-excluded or --delete-after are specified.

Below is the patch i checked in.

We should also automatically enable --backup if --suffix or
--backup-dir are specified.  But that should be handled like
--delete is.  The --progress, --verbose combo requires
special handling due -P and verbosity's incremental nature.


Index: options.c
===================================================================
RCS file: /data/cvs/rsync/options.c,v
retrieving revision 1.113
diff -u -r1.113 options.c
--- options.c	5 Aug 2003 17:56:54 -0000	1.113
+++ options.c	6 Aug 2003 06:42:12 -0000
@@ -641,6 +641,9 @@
 		exit_cleanup(RERR_SYNTAX);
 	}
 
+	if (do_progress && !verbose)
+		verbose = 1;
+
 	*argv = poptGetArgs(pc);
 	if (*argv)
 		*argc = count_args(*argv);
Index: rsync.yo
===================================================================
RCS file: /data/cvs/rsync/rsync.yo,v
retrieving revision 1.125
diff -u -r1.125 rsync.yo
--- rsync.yo	1 Aug 2003 00:50:23 -0000	1.125
+++ rsync.yo	6 Aug 2003 06:42:13 -0000
@@ -832,9 +832,7 @@
 dit(bf(--progress)) This option tells rsync to print information
 showing the progress of the transfer. This gives a bored user
 something to watch.
-
-This option is normally combined with -v. Using this option without
-the -v option will produce weird results on your display.
+Implies --verbose without incrementing verbosity.
 
 dit(bf(-P)) The -P option is equivalent to --partial --progress. I
 found myself typing that combination quite often so I created an

-- 
________________________________________________________________
	J.W. Schultz            Pegasystems Technologies
	email address:		jw at pegasys.ws

		Remember Cernan and Schmitt