"-b --suffix '' --delete --backup-dir /path/" combination does not act as expected

[Wayne Davison]

[I apparently lost some of my email that was sent to my samba.org
address due to some bogus spam filtering involving my use of spamcop.org
(which I just turned off).  I looked up your reply in a mailing list
archive on the web...]

> My only concern is that i don't like depending on
> strcmp(backup_suffix, BACKUP_SUFFIX).

The new test is more complex than that (you cited the old test).  The
new test ensures that we send the suffix value if it differs from the
default suffix value.  The 3 examples you listed are how the new code
behaves.

> I don't care for "deleting" here either

I've thought about it some more, and I think it's actually correct.  The
backing up of the files is something that is occurring for both changed
and deleted files, so we should mention the files that are deleted in
the same way they would be mentioned if --backup wasn't specified.  I
wouldn't want to see the backup messages moved from verbose level 2 to
level 1 because they would be very redundant (since everything that gets
changed or deleted gets backed up).

I tweaked my code just a bit more and went ahead and checked it into CVS.
If there are still areas of contention, we can hash them out and check
in changes, as needed.

..wayne..