Malformed address warnings in 2.5.6 rsyncd.log
John Van Essen
vanes002 at umn.edu
Thu Apr 10 16:34:29 EST 2003
Non-numeric tokens in the hosts allow list (and prolly the deny list as
well) in rsyncd.conf generate "malformed address" warnings in rsyncd.log.
In 2.5.5, there was a check to prevent trying to match the IP address
against access list tokens that did not have a digit as the first
character. That check is missing in 2.5.6.
Here's the patch to fix the problem (using a slightly different check):
--- access.c.orig Mon Jan 20 08:46:28 2003
+++ access.c Thu Apr 10 01:52:40 2003
@@ -79,6 +79,11 @@
p = strchr(tok,'/');
if (p) *p = 0;
+ /* skip if last char is not a digit (i.e. not an address) */
+ /* (don't check first char - might be 11.22.33.44.an.isp) */
+ if ( !*tok ) return 0; /* nothing to check */
+ if ( !isdigit(tok[strlen(tok)-1]) ) return 0;
+
memset(&hints, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
--
John Van Essen <vanes002 at umn.edu>
More information about the rsync
mailing list