MD4 checksum fix
jw at pegasys.ws
Tue Apr 8 06:52:12 EST 2003
On Mon, Apr 07, 2003 at 02:33:28PM -0600, Eric Whiting wrote:
> This patch does not change PROTOCOL_VERSION in rsync.h. Was I supposed to patch
> against a CVS version?
> I'll change the value manually and retest.
Craig says the patch is against 2.5.6. I expect it will
apply cleanly to CVS.
You will need to change the PROTOCOL_VERSION manually. I
have not bumped it yet in CVS. I am holding off doing so
just so to reduce the chance of someone getting a protocol
27 with only one dependant patch.
> cbarratt at users.sourceforge.net wrote:
> > > > I agree, they should be done together. I don't have my original
> > > > patch but I can reimplement it with the correct remote_version
> > > > dependence and send it in the next couple of days (by Thursday
> > > > evening). My intent is the minimal set of changes, rather than
> > > > changing the internals.
> > >
> > > That is a workable timeframe, thanks.
> > Two days late, but here is the patch against 2.5.6. This implements the
> > following changes:
> > - for protocol version >= 27, mdfour_tail() is called when the block size
> > (including checksum_seed) is a multiple of 64. Previously it was not
> > called, giving the wrong MD4 checksum.
> > - for protocol version >= 27, a 64 bit bit counter is used in mdfour.c as
> > required by the RFC. Previously only a 32 bit bit counter was used,
> > causing incorrect MD4 file checksums for file sizes >= 512MB - 4.
> > Craig
More information about the rsync