MD4 checksum fix

Donovan Baarda abo at minkirri.apana.org.au
Sun Apr 6 16:09:30 EST 2003


On Sun, 2003-04-06 at 10:06, cbarratt at users.sourceforge.net wrote:
> > > I agree, they should be done together.  I don't have my original
> > > patch but I can reimplement it with the correct remote_version
> > > dependence and send it in the next couple of days (by Thursday
> > > evening).  My intent is the minimal set of changes, rather than
> > > changing the internals.
> > 
> > That is a workable timeframe, thanks.
> 
> Two days late, but here is the patch against 2.5.6.  This implements the
> following changes:
> 
>  - for protocol version >= 27, mdfour_tail() is called when the block size
>    (including checksum_seed) is a multiple of 64.  Previously it was not
>    called, giving the wrong MD4 checksum.
> 
>  - for protocol version >= 27, a 64 bit bit counter is used in mdfour.c as
>    required by the RFC.  Previously only a 32 bit bit counter was used,
>    causing incorrect MD4 file checksums for file sizes >= 512MB - 4.

It looks like it will work OK, but it's kinda ugly in that starts
embedding version stuff into the mdfour implementation. Still... its
better than the nothing I've produced :-)

-- 
----------------------------------------------------------------
Donovan Baarda                http://minkirri.apana.org.au/~abo/
----------------------------------------------------------------



More information about the rsync mailing list