rsync 2.5.5 core dump

Sviatoslav Sviridov svd at lintec.minsk.by
Mon Oct 14 11:07:01 EST 2002


On Sun, 13 Oct 2002 12:24:07 -0400
Michael Richardson <mcr at sandelman.ottawa.on.ca> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> 
> 
> I added the following code to log_exit():
> 
> void log_exit(int code, const char *file, int line)
> {
>         static int error_count=0;
> 
> 
>         if(error_count++ > 10) {
>                 abort();
>         }
> 
> 
> To force it to bail earlier instead of overflowing the stack.
> 
> As you can see at frame #50, it is trying to log that the connection went
> away unexpectantly. I don't know why that might have happened, but clearly
> the handling of this error is incorrect. Note that the client terminates 
> with non-zero error status (I don't know which one, but, I could find out),
> which causes our cron job to fail, which is why we noticed this in the first
> place. 

I think, it's better to avoid recoursive calling of exit_cleanup(), here is
main problem.

-- 
Sviatoslav Sviridov
[mailto:svd at lintec.minsk.by] [ICQ#10845380] [Lintec Project] [MLUG]
--
Beware the one behind you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rsync-2.5.5-alt-cleanup.patch
Type: application/octet-stream
Size: 359 bytes
Desc: not available
Url : http://lists.samba.org/archive/rsync/attachments/20021014/b9fcae4a/rsync-2.5.5-alt-cleanup.obj


More information about the rsync mailing list