2.5.5 build ignores $CPPFLAGS

[Green, Paul]

Umm, I'm wrong, and I apologize to Paul. My patch changes not only the
source file compilation line, but the link-only invocations of GCC. While
there is no harm in passing CPPFLAGS to GCC when it is linking, it isn't
needed, and for clarity should not be done.  Go with his patch, and I'll
update mine and resend it.

Thanks
PG
--
Paul Green, Senior Technical Consultant, Stratus Technologies.
Voice: +1 (978) 461-7557; FAX: +1 (978) 461-3610
Speaking from Stratus not for Stratus


> -----Original Message-----
> From: Green, Paul [mailto:Paul.Green at stratus.com]
> Sent: Wednesday, November 13, 2002 8:25 AM
> To: 'prj at po.cwru.edu'; rsync at lists.samba.org
> Subject: RE: 2.5.5 build ignores $CPPFLAGS
> 
> 
> This patch is incomplete and should not be used.  I think 
> that my patch,
> submitted Sept 9th and resubmitted Oct 10th has the complete 
> set of changes
> to Makefile.in to add CPPFLAGS (plus a few more cleanups).
> 
> Thanks.
> PG
> --
> Paul Green, Senior Technical Consultant, Stratus Technologies.
> Voice: +1 (978) 461-7557; FAX: +1 (978) 461-3610
> 
> 
> 
> > -----Original Message-----
> > From: prj at po.cwru.edu [mailto:prj at po.cwru.edu]
> > Sent: Tuesday, November 12, 2002 11:11 PM
> > To: rsync at lists.samba.org
> > Subject: 2.5.5 build ignores $CPPFLAGS
> > 
> > 
> > (I'm not subscribed; Mail-Followup-To set.)
> > 
> > Contrary to the claim in the output of ./configure --help, $CPPFLAGS
> > is in fact not influential.
> > 
> > --- rsync-2.5.5/Makefile.in~    2002-03-24 23:36:34.000000000 -0500
> > +++ rsync-2.5.5/Makefile.in     2002-11-12 17:52:04.000000000 -0500
> > @@ -9,6 +9,7 @@
> >  LIBS=@LIBS@
> >  CC=@CC@
> >  CFLAGS=@CFLAGS@
> > +CPPFLAGS=@CPPFLAGS@
> >  LDFLAGS=@LDFLAGS@
> >  
> >  INSTALLCMD=@INSTALL@
> > @@ -45,7 +46,7 @@
> >  # note that the -I. is needed to handle config.h when using VPATH
> >  .c.o:
> >  @OBJ_SAVE@
> > -       $(CC) -I. -I$(srcdir) $(CFLAGS) -c $< @CC_SHOBJ_FLAG@
> > +       $(CC) -I. -I$(srcdir) $(CPPFLAGS) $(CFLAGS) -c $< 
> > @CC_SHOBJ_FLAG@
> >  @OBJ_RESTORE@
> >  
> >  all: rsync
> > 
> > 
> > 
> > paul
> > -- 
> > To unsubscribe or change options: 
> > http://lists.samba.org/mailman/listinfo/rsync
> > Before posting, read: 
> > http://www.tuxedo.org/~esr/faqs/smart-questions.html
> > 
> -- 
> To unsubscribe or change options: 
http://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.tuxedo.org/~esr/faqs/smart-questions.html