Status Query - Please respond - Re: Patch to avoid 'Connection reset by peer' error for rsync on cygwin
maxb at ukf.net
Fri May 17 04:08:02 EST 2002
Mark - Point taken. But even if it worked correctly everywhere, to me there
seems to be something aesthetically wrong about just letting sockets close
themselves. Kind of like a malloc() without a free().
Wayne - Wouldn't the atexit solution require that we keep a list of fds to
close? Anyway, I think it is now up to me to make a patch which fixes the
problem in the most discreet and unsweeping manner possible, and then post it
for Martin to decide.
Mark Eichin <eichin at thok.org> wrote:
>> Just because Linux lets you get away without it doesn't mean its a good idea.
> Except this has nothing to do with linux - this is unix behaviour that
> goes "all the way back", it's part of the process model. It's part of
> what exiting *does*, so it *is* a bug in cygwin if it isn't doing the
> cleanup (and really, cygwin does so many other bizarre things under
> the covers to create Unix/POSIX semantics in the Very Different win32
> environment, I'm more than a little surprised it isn't doing this
> already... skeptical, even, though I haven't been deep inside cygwin
> in years.)
Wayne Davison <wayned at users.sourceforge.net> wrote:
> On Thu, 16 May 2002, Max Bowsher wrote:
>> That just moves the shutdown call from where you finish with the fd to
>> where you start using the fd - that's got to be less intuitive.
> Being more or less intuitive is not the point. The idea was to have as
> little cygwin kludge code as possible. Thus, we'd just have one call to
> atexit() during startup, with the single cleanup function being able to
> handle any and all opened sockets, and we're done (if this is even
> feasible -- I haven't looked into it). This was prompted by Martin's
> statement that he considers this a cygwin bug -- I was assuming that he
> didn't want to make sweeping changes to all the cleanup code in rsync.
> Whether he wants to handle this in a more invasive manner is up to him.
More information about the rsync