[PATCH] rsync kills all user processes on fork failure

Paul Haas paulh at hamjudo.com
Thu May 9 16:23:01 EST 2002

On Thu, 9 May 2002, Dave Dykstra wrote:

> On Wed, May 08, 2002 at 09:44:25PM -0700, Jos Backus wrote:
> > On Wed, May 08, 2002 at 11:31:18PM -0400, Bob Byrnes wrote:
> > > http://rsync.samba.org/cgi-bin/rsync/incoming?id=2762;user=guest;selectid=2762

> > Fwiw, the patch looks good to me. rsync doesn't seem to handle -1 == fork()
> > here, leading to the problem described.

> What's the best fix against the current CVS?  Should we back out the
> previous fix because that one only solved half the problem?  Somebody
> please provide an updated patch.

My patch inspired version 1.109 of rsync/util.c,
but there's other stuff there too, so you don't want to just undo it.

I'm off to a meeting now.  If no one else gets around to it, I can
repackage Bob's patch sometime late tomorrow. The context has changed a
bit, so the original won't apply without a few minor tweaks.

In addition to the kill -1 stuff, Bob also had a few lines of code to
prevent going off the end of the all_pids[] array.

> - Dave Dykstra

More information about the rsync mailing list