Fix for batch mode (was Re: batch mode maintainability)

[Dave Dykstra]

On Wed, Jan 23, 2002 at 03:41:36PM -0800, Jos Backus wrote:
> On Wed, Jan 23, 2002 at 11:05:15AM -0600, Dave Dykstra wrote:
> > On Wed, Jan 23, 2002 at 04:37:53PM +1100, Martin Pool wrote:
> > > On 17 Jan 2002, Jos Backus <josb at cncdsl.com> wrote:
> > > When you get a chance, could you please look at writing some more
> > > documentation about batch mode?  It would also be good to try to split
> > > out the code a little more.   All the if(read_batch) conditionals look
> > > highly breakable.
> 
> Yes, I'll look at doing some documentation. What about a paragraph titled
> ``About batch mode'' with a little explanation how it works, how it differs
> from normal rsync operation and a small example?

Sounds like a good idea. Of course, refer to the section under the entries
for --write-batch and --read-batch.


...
> > Interesting tidbit: it apparently works with -W, because I noticed that
> > when I make a small change to a large file the rsync_delta* file is large
> > if my original destination is on the same machine as the source (because in
> > that case -W is implied) but if my original destination is on a remote
> > machine the rsync_delta* file is small, and both cases produce the correct
> > result.  Maybe -W should never be implied when --write-batch is on.
> 
> Meaning that with --write-batch you'd always get the small delta file (-W
> turned off)?

Yes.

- Dave