when using --backup-dir: why not make_bak_dir() . . .

Buck Huppmann buckh at pobox.com
Mon Dec 9 22:16:01 EST 2002


here (in keep_backup())?

--- backup.c.orig       Mon Dec  9 17:02:36 2002
+++ backup.c    Mon Dec  9 17:03:50 2002
@@ -273,6 +273,7 @@
 
	/* move to keep tree if a file */
	if(!kept) {
+		make_bak_dir(fname,backup_dir);
		if (!robust_move (fname, keep_name))
			rprintf(FERROR, "keep_backup failed %s -> %s : %s\n",
				fname, keep_name, strerror(errno));

this reconstructs parent directory permissions more in keeping with
my (humble) expectations, in addition to being consistent with the
way all ~S_IFREG links' parents are produced

just curious



More information about the rsync mailing list