rsync server over SSH [includes code patches]

Dave Dykstra dwd at bell-labs.com
Thu Nov 29 09:44:12 EST 2001


On Thu, Nov 29, 2001 at 09:11:58AM +1100, Martin Pool wrote:
...
> >     1. remove AC_FUNC_MEMCMP from configure.in because it causes Sunos
> > 	4.1.4 to die.  memcmp() there fails the "8-bit clean" test, but it
> > 	doesn't matter because memcmp() in rsync is only used to test if
> > 	something is equal or not equal, not to compare if it is less or
> > 	greater.  
> 
> What breaks if we leave it in?  Is memcmp a compiler intrinsic or something 
> like that?
> 
> No objection to taking it out, I'm just curious.

It says "don't know how to build memcmp.o".  The configure rule only adds
"memcmp.o" to $LIBOBJS, which was not used before.



> >       AC_FUNC_MEMCMP has always been in configure.in but before
> > 	now it has been ignored because @LIBOBJS@ was not used in
> > 	Makefile.in now and that was the only thing it affected.
> 
> I think it is, isn't it?  LIBOBJS = ... @LIBOBJS@, etc.

It is now, but it wasn't a week ago.  See
    http://pserver.samba.org/cgi-bin/cvsweb/rsync/Makefile.in.diff?r1=1.55&r2=1.56&f=h

- Dave




More information about the rsync mailing list