rsync server over SSH [includes code patches]
dwd at bell-labs.com
Thu Nov 29 09:02:38 EST 2001
On Wed, Nov 28, 2001 at 10:26:35AM +1100, Martin Pool wrote:
> I'm not sure if you've seen this:
> It's a pretty good tool, since I don't have direct access to (for
> example) a CRAY. The downside is that it requires changes to be
> checked in to HEAD for them to be tested.
Yes, I had seen it but haven't volunteered my build machines because the
build servers download code to execute over the open internet using only
an rsync server, which gives no assurance that it hasn't been spoofed.
Hopefully after the rsync server over SSH patch is integrated we can use
that and I won't worry any more.
Here's more fixes to build on three more platforms:
1. remove AC_FUNC_MEMCMP from configure.in because it causes Sunos
4.1.4 to die. memcmp() there fails the "8-bit clean" test, but it
doesn't matter because memcmp() in rsync is only used to test if
something is equal or not equal, not to compare if it is less or
greater. AC_FUNC_MEMCMP has always been in configure.in but before
now it has been ignored because @LIBOBJS@ was not used in
Makefile.in now and that was the only thing it affected.
2. Amdahl's UTS 2.1.2 defines NO_ADDRESS instead of NO_DATA.
3. Sunos 4.1.4 and Unixware 1.1.2 don't have stderr defined in unistd.h.
Note: I see that rsync.h has an #ifdef HAVE_UNISTD_H around including
unistd.h, perhaps it would be better to include rsync.h instead of
most of the includes at the beginning of getaddrinfo.c
4. Unixware 1.1.2 and UTS 2.1.2 had missing S_ISLNK and S_ISSOCK
macros which are defined in rsync.h. Maybe all the lib files
should just include rsync.h.
- Dave Dykstra
--- configure.in.O Wed Nov 28 13:59:42 2001
+++ configure.in Wed Nov 28 13:59:49 2001
@@ -283,7 +283,6 @@
AC_CHECK_FUNCS(waitpid wait4 getcwd strdup strerror chown chmod mknod)
AC_CHECK_FUNCS(fchmod fstat strchr readlink link utime utimes strftime)
--- lib/getaddrinfo.c.O Wed Nov 28 01:11:45 2001
+++ lib/getaddrinfo.c Wed Nov 28 12:59:05 2001
@@ -71,6 +71,12 @@
# include <netdb.h>
+#define NO_DATA NO_ADDRESS
@@ -85,6 +91,7 @@
--- lib/permstring.c.O Wed Nov 28 13:14:32 2001
+++ lib/permstring.c Wed Nov 28 13:14:49 2001
@@ -18,6 +18,7 @@
Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
More information about the rsync