Cosmetic code cleanup?

Martin Pool mbp at samba.org
Sat Dec 8 00:07:22 EST 2001


On  6 Dec 2001, Jos Backus <josb at cncdsl.com> wrote:
> Here's a list of cosmetic changes I'd be willing to make to the code in order
> to make it more consistent, which stylisticly it currently is not.
> 
> - separate function definitions by 2 newlines
> - put spaces after commas in arg lists
> - put spaces around assignments
> - remove trailing spaces
> - change space indents to tabs
> - fix multiline comments
> - remove redundant /* dw */ comments (Deborah Weiss is already
> - credited in the
>   documentation)

Yes, I agree.  I'll just run GNU indent over it and commit directly --
no need to send a big noisy patch unless you really want to.

--
Martin




More information about the rsync mailing list