[clug] Updated version of VICI

[Brenton Ross]

On Fri, 2018-05-04 at 22:30 +1000, Duncan Roe via linux wrote:

> On Fri, May 04, 2018 at 03:33:02PM +1000, linux wrote:
> > On Fri, 2018-05-04 at 11:40 +1000, Duncan Roe via linux wrote:
> >
> > > On Thu, May 03, 2018 at 09:58:52PM +1000, linux wrote:
> > > > On Thu, 2018-05-03 at 20:47 +1000, Bryan Kilgallin via linux wrote:
> > > [...]
> > > > Since Duncan has got his Slackware version to build I would like to hear
> > > > what happens when he runs "make check" to test it.
> > > >
> > > > The next thing on my schedule is to update the user guide. This release
> > > > has new stuff for monitoring and debugging scripts and there are
> > > > currently no instructions on how to use it.
> > > >
> > > > Cheers
> > > > Brenton
> > > >
> > > >
> > > I ran a quick make check on 683 before upgrading to 689 (which will take a
> > > little while). I hope these resuts are helpful:
> > >
> > > > 11:27:42$ less src/cfi/UnitTest/test-suite.log
> > > > ========================================
> > > >    vici 0.10: UnitTest/test-suite.log
> > > > ========================================
> > > >
> > > > # TOTAL: 3
> > > > # PASS:  0
> > > > # SKIP:  0
> > > > # XFAIL: 0
> > > > # FAIL:  3
> > > > # XPASS: 0
> > > > # ERROR: 0
> > > >
> > > > .. contents:: :depth: 2
> > > >
> > > > FAIL: cfitest
> > > > =============
> > > >
> > > > Exception: Error: Cannot find configuration file in PECHD:-i:VICI_CONF:vici.xml:.local/share/vici/vici.xml:$VICI/src/cfi/vici.xml:$VICI/share/vici/vici.xml:$VICI/vici.xml [xini.cpp:56]
> > > >
> > > > FAIL: cditest
> > > > =============
> > > >
> > > > Exception: Error: Cannot find configuration file in PECHD:-i:VICI_CONF:vici.xml:.local/share/vici/vici.xml:$VICI/src/cfi/vici.xml:$VICI/share/vici/vici.xml:$VICI/vici.xml [xini.cpp:56]
> > > >
> > > > FAIL: plugintest
> > > > ================
> > > >
> > > > Exception: Error: Cannot find configuration file in PECHD:-i:VICI_CONF:vici.xml:.local/share/vici/vici.xml:$VICI/src/cfi/vici.xml:$VICI/share/vici/vici.xml:$VICI/vici.xml [xini.cpp:56]
> > > > src/cfi/UnitTest/test-suite.log (END)
> > >
> > > Cheers ... Duncan.
> > >
> >
> > Duncan,
> >
> > More puzzling than helpful I'm afraid.
> > To not be able to find $VICI/src/cfi/vici.xml means that either $VICI is
> > no longer valid or something very bad has happened in the code -
> > something we probably won't be able to debug.
> >
> > Not to worry - I have two states - Confused or Bored - and I really hate
> > being bored.
> > Brenton
> >
> Hi Brenton,
> 
> Better news - I can now get 2 of the 3 tests to pass. I had to do 4 things:
> 
>  1. export VICI=$PWD/stage/usr
>  2. (cd $VICI; mkdir lib; cd lib; ln -s ../lib64/vici)
>  3. mkdir -p $VICI/var/vici
>  4. mkdir -p $VICI/logs
> 
> Step 2 should only be performed on x86_64 systems. After that, make check
> reports:
> 
>  PASS: cfitest
>  PASS: cditest
>  FAIL: plugintest
> 
> UnitTest/test-suite.log contains:
> 
> > ========================================
> >    vici 0.10: UnitTest/test-suite.log
> > ========================================
> >
> > # TOTAL: 3
> > # PASS:  2
> > # SKIP:  0
> > # XFAIL: 0
> > # FAIL:  1
> > # XPASS: 0
> > # ERROR: 0
> >
> > .. contents:: :depth: 2
> >
> > FAIL: plugintest
> > ================
> >
> > Using config: /tmp/DRbuilds/vici_0.10/stage/usr/share/vici/vici.xml
> > Plug-in name [dummy] from library not in config
> > Created 2 factories
> > Removing 2 factories
> > Exception: Error: Failed to get plug-in [plugintest.cpp:60]
> 
> any idea what to do about this?
> 
> --------------------
> 
> In other news, I have packaged vici for Slackware. You can get it from
> 
> https://github.com/duncan-roe/SlackBuilds/tree/master/vici
> 
> The dependency list is likely incomplete. The 4 test items are yet to be
> addressed: for 1. I suggest there should be vici.sh and vici.csh in
> /etc/profile.d. Items 2-4 could be handled by a post_install script in the
> build.
> 
> Cheers ... Duncan.
> 

Duncan,

You do realise that VICI has 14 sub-projects, 8 of which have
significant tests ? You have only reported on the first project (cfi).

Its taken me a while to work out what happened, but I think I have it
now:
When you reset $VICI to point into the stage directory it meant that it
was unable to find the configuration file that has the test stuff in it.
It is supposed to be using $VICI/src/persist/vici-dev.xml. This has all
the plug-in stuff for testing.
The make check defines the TEST_ENVIRONMENT variable to set the
VICI_CONF variable to this file.

Note that "make check" should work before "make install".

You should not not need to go near the stage directory. 
Background:
Typically in an autotools project each subproject can see the
uninstalled libraries of other subprojects.
I wanted a more isolated arrangement where the contents of subprojects
remained private until they were published/installed.
This broke the make all command when building the entire suite of
projects.
I fixed this by having make all do an install into the stage directory
for each subproject.
Hence it is simply a means for the subprojects to find stuff created by
other subprojects.

I think doing a package is getting a bit ahead of ourselves. There is
still another round of development necessary before users should be let
loose on it.

Cheers
Brenton