[linux-cifs-client] [PATCH] cifs: don't ignore cifs_posix_open_inode_helper return value

Suresh Jayaraman sjayaraman at suse.de
Fri May 28 04:48:19 MDT 2010


.and ensure that we propagate the error back to avoid any surprises.

Signed-off-by: Suresh Jayaraman <sjayaraman at suse.de>
---
 fs/cifs/file.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index a83541e..ae89625 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -309,8 +309,8 @@ int cifs_open(struct inode *inode, struct file *file)
 			   on read only files needed here */
 
 			pCifsFile = cifs_fill_filedata(file);
-			cifs_posix_open_inode_helper(inode, file, pCifsInode,
-						     oplock, netfid);
+			rc = cifs_posix_open_inode_helper(inode, file,
+					pCifsInode, oplock, netfid);
 			goto out;
 		} else if ((rc == -EINVAL) || (rc == -EOPNOTSUPP)) {
 			if (tcon->ses->serverNOS)
-- 
1.6.4.2



More information about the linux-cifs-client mailing list