[linux-cifs-client] [PATCH] cifs: implement drop_inode superblock op

Raja R Harinath harinath at hurrynot.org
Tue May 25 20:16:58 MDT 2010


Hi,

Jeff Layton <jlayton at redhat.com> writes:

[snip]
>  static const struct super_operations cifs_super_ops = {
>  	.put_super = cifs_put_super,
>  	.statfs = cifs_statfs,
>  	.alloc_inode = cifs_alloc_inode,
>  	.destroy_inode = cifs_destroy_inode,
> -/*	.drop_inode	    = generic_delete_inode,
> -	.delete_inode	= cifs_delete_inode,  */  /* Do not need above two
> +	.drop_inode	= cifs_drop_inode,
> +/*	.delete_inode	= cifs_delete_inode,  */  /* Do not need above two
>  	functions unless later we add lazy close of inodes or unless the
>  	kernel forgets to call us with the same number of releases (closes)
>  	as opens */

I think the comment needs to be updated, at least to decrement the "two
functions".

- Hari



More information about the linux-cifs-client mailing list