[linux-cifs-client] [PATCH] build mount.smb2 from mount.cifs

[Steve French]

On Tue, May 11, 2010 at 8:24 AM, Jeff Layton <jlayton at redhat.com> wrote:
> On Fri, 7 May 2010 12:29:22 -0500
> Steve French <smfrench at gmail.com> wrote:
>
>> Resending with updates from Jeff Layton comments included.
>>
>> On Fri, May 7, 2010 at 12:26 PM, Steve French <smfrench at gmail.com> wrote:
>> > mount.smb2 has different help (many fewer mount options) and different
>> > fsname, but otherwise can reuse all of the good work Jeff did on
>> > mount.cifs.  This patch allow mount.cifs to detect if run as
>> > mount.smb2 (to display different help and fsname).
>>
>>
>>
>
> Looks good overall. A couple of small whitespace and formatting issues.
> Does the attached patch look ok? Eventually we'll probably want to have
> "make install" add a mount.smb2 symlink, but we probably shouldn't do
> that until the filesystem is in mainline kernels.

Jeff,
Your updates  to mount.cifs patch look fine to me, and I agree that
we can wait on updating make install (to do the symlink)
until the file system is in mainline.

On the kernel code, at the moment I am working on fixing a readdir bug
(one of the locking calls is failing right after SMB2 close on the
directory handle),
and adding the minimal required support for async and SMB2 compounding.
After talking with jra yesterday, realized that the smb2 kernel code wasn't
checking for async and compound responses but that this is required
(and now that the Samba server's SMB2 support is improving rapidly
we are far more likely to see async responses when a server
side command has to block even briefly), so have been updating
the code which validates the header e.g.


-- 
Thanks,

Steve