[linux-cifs-client] CIFSSMBOpen prototype sparse warning

Steve French smfrench at gmail.com
Thu Mar 18 22:35:34 MDT 2010


Any objections to cleaning up the sparse warning below:

fs/cifs/file.c:374:67: warning: incorrect type in argument 8
(different signedness)
fs/cifs/file.c:374:67:    expected int *pOplock
fs/cifs/file.c:374:67:    got unsigned int *<noident>
fs/cifs/file.c:383:66: warning: incorrect type in argument 8
(different signedness)
fs/cifs/file.c:383:66:    expected int *pOplock
fs/cifs/file.c:383:66:    got unsigned int *<noident>
fs/cifs/file.c:401:38: warning: incorrect type in argument 6
(different signedness)
fs/cifs/file.c:401:38:    expected int *oplock
fs/cifs/file.c:401:38:    got unsigned int *<noident>
fs/cifs/file.c:512:31: warning: cast from restricted fmode_t
fs/cifs/file.c:534:52: warning: incorrect type in argument 8
(different signedness)
fs/cifs/file.c:534:52:    expected int *pOplock
fs/cifs/file.c:534:52:    got unsigned int *<noident>

We define it with unsigned int *

fs/cifs/cifsproto.h:extern int CIFSSMBOpen(const int xid, struct
cifsTconInfo *tcon,
fs/cifs/cifsproto.h-			const char *fileName, const int disposition,
fs/cifs/cifsproto.h-			const int access_flags, const int omode,
fs/cifs/cifsproto.h-			__u16 *netfid, int *pOplock, FILE_ALL_INFO *,

but often call it with __u32 *
I realize it is harmless, but like to remove warnings where reasonably possible.

-- 
Thanks,

Steve


More information about the linux-cifs-client mailing list