[linux-cifs-client] [PATCH] accept all supported values for dir_mode

[Scott Lovenberg]

>
> > -     if (strncmp(token, "dir_mode", 8) == 0)
> > +     if (strncmp(token, "dir_mode", 4) == 0 || strncmp(token, "dirm", 4)
> == 0)
>                                       ^^^^
> Sigh. But I can confirm that this is similarly broken in the kernel
> so we have little choice but to live with it here.
>
> That's exactly how I felt about this fix.  Do you have any feelings on
fixing this on both sides to accept only the full strings?  It might cause
regressions for people, so the kernel patch will probably be pulled by
Redhat, Suse and Debian (and anyone else backporting kernel patches for long
term releases) maintainers.
It seems like the right thing to do, but if it's just going to cause extra
work and be yanked either way... well, that's one step forward, two
backwards.


-- 
Peace and Blessings,
-Scott.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.samba.org/pipermail/linux-cifs-client/attachments/20100607/66ffa2cf/attachment.html>