[linux-cifs-client] [patch] Attempt #2 to handle null nameidata

Eugene Teo eugeneteo at kernel.sg
Thu Apr 29 08:12:22 MDT 2010


On Thu, Apr 29, 2010 at 9:51 PM, Shirish Pargaonkar
<shirishpargaonkar at gmail.com> wrote:
> On Thu, Apr 29, 2010 at 6:16 AM, Jeff Layton <jlayton at samba.org> wrote:
>> On Thu, 29 Apr 2010 15:56:02 +0530
>> Suresh Jayaraman <sjayaraman at suse.de> wrote:
>>
>>> On 04/09/2010 01:28 AM, Jeff Layton wrote:
>>> > On Thu, 8 Apr 2010 14:40:47 -0500
>>> > Shirish Pargaonkar <shirishpargaonkar at gmail.com> wrote:
>>> >
>>> >> On Thu, Apr 8, 2010 at 2:34 PM, Jeff Layton <jlayton at samba.org> wrote:
>>> >>> On Wed, �7 Apr 2010 11:19:10 -0500
>>> >>> shirishpargaonkar at gmail.com wrote:
>>> >>>
>>> >>>> While creating a file on a server which supports unix extensions
>>> >>>> such as Samba, if a file is being created which does not supply
>>> >>>> nameidata (i.e. nd is null), cifs client can oops when calling
>>> >>>> cifs_posix_open.
>>> >>>>
>>> >>>> Signed-off-by: Shirish Pargaonkar <shirishpargaonkar at gmail.com>
>>> >>>> Reported-by: Eugene Teo <eugeneteo at kernel.sg>
>>>
>>> >
>>> > We'll need to take this patch in the interim though to fix the
>>> > immediate oops.
>>> >
>>>
>>> Do we need to Cc -stable as well as the issue seem to be reproducible on
>>> kernel versions > 2.6.29-rc6?
>>>
>>> Thanks,
>>>
>>
>> Can someone clarify how to reproduce this oops? I think that the only
>> place where this function gets called with NULL nameidata is from nfsd
>> and the export ops for cifs are just stubs. Has this actually been seen
>> in the field or was it just found via inspection?
>>
>> --
>> Jeff Layton <jlayton at samba.org>
>
> As far as I know, by inspection.
> Eugene, can you please comment on this?

It was found by inspection. Did not attempt to reproduce the issue.

Eugene


More information about the linux-cifs-client mailing list