[linux-cifs-client] [PATCH] cifs: fix locking and list handling code in cifs_open and its helper

Steve French smfrench at gmail.com
Fri Sep 25 11:59:54 MDT 2009


On Fri, Sep 25, 2009 at 8:53 AM, Jeff Layton <jlayton at redhat.com> wrote:
> The patch to remove cifs_init_private introduced a locking imbalance. It
> didn't remove the leftover list addition code and the unlocking in that
> function. cifs_new_fileinfo does the list addition now, so there should
> be no need to do it outside of that function.
>
> pCifsInode will never be NULL, so we don't need to check for that. This
> patch also gets rid of the ugly locking and unlocking across function
> calls.
>
> Signed-off-by: Jeff Layton <jlayton at redhat.com>
> Acked-by: Steve French <sfrench at us.ibm.com>

merged



-- 
Thanks,

Steve


More information about the linux-cifs-client mailing list