[linux-cifs-client] Re: [PATCH 06/13] cifs: add new cifs_iget function and convert unix codepath to use it

[Christoph Hellwig]

On Wed, May 27, 2009 at 08:30:27AM -0400, Jeff Layton wrote:
> In order to unify some codepaths, introduce a common cifs_fattr struct
> for storing inode attributes. The different codepaths (unix, legacy,
> normal, etc...) can fill out this struct with inode info. It can then
> be passed as an arg to a common set of routines to get and update inodes.
> 
> Add a new cifs_iget function that uses iget5_locked to identify inodes.
> This will compare inodes based on the uniqueid value in a cifs_fattr
> struct.
> 
> Rather than filling out an already-created inode, have
> cifs_get_inode_info_unix instead fill out cifs_fattr and hand that off
> to cifs_iget. cifs_iget can then properly look for hardlinked inodes.
> 
> With this, we should then have proper hardlink detection and can
> eventually get rid of some nasty CIFS-specific hacks for handing them.
> 
> Fixing the unix readdir codepath will be done in a later patch.

Looks good to me:


Reviewed-by: Christoph Hellwig <hch at lst.de>