[linux-cifs-client] Re: [PATCH] cifs: fix pointer initialization and checks in cifs_follow_symlink

Jeff Moyer jmoyer at redhat.com
Mon May 18 16:58:14 GMT 2009


Jeff Layton <jlayton at redhat.com> writes:

> This is a respin of the patch posted yesterday. It includes a fix for
> a bogus NULL pointer check that Jeff Moyer spotted.
>
> It's possible for CIFSSMBQueryUnixSymLink to return without setting
> target_path to a valid pointer. If that happens then the current
> value to which we're initializing this pointer could cause an oops
> when it's kfree'd.
>
> CIFSSMBQueryUnixSymLink also has an incorrect NULL pointer check.
> Thanks to Jeff Moyer for pointing that out.
>
> Reported-by: Jeff Moyer <jmoyer at redhat.com>
> Signed-off-by: Jeff Layton <jlayton at redhat.com>

Reviewed-by: Jeff Moyer <jmoyer at redhat.com>


More information about the linux-cifs-client mailing list