[linux-cifs-client] Re: [PATCH 0/5] cifs: unicode related buffer overrun fixes for -stable

Suresh Jayaraman sjayaraman at suse.de
Thu May 7 04:28:40 GMT 2009


Steve French wrote:
> On Wed, May 6, 2009 at 6:32 AM, Suresh Jayaraman <sjayaraman at suse.de> wrote:
>> Hi Steve,
>>
>> Here's a minimal list of fixes that both Jeff and I think should go for
>> -stable. All of these are addressing destination buffer overruns.
>>
>> I have mostly refreshed the identitied commits from upstream/cifs-2.6,
>> taken as-is/few relevant chunks. Patch 4/5 needs attention as upstream
>> fixes this differently. And 5/5 already has -stable in the CC.
>>
>> 01-cifs-fix-buffer-size-for-nativeFileSystem
>> 02-cifs-fix-temp-buffer-size-in-cifs_readdir
>> 03-cifs-fix-dest-buffer-size-in-cifs_strncpy_to_host
>> 04-cifs-fix-cifs_convertUCSpath
>> 05-cifs-fix-unicode-string-alignment-in-session-setup
>>
>> I've not CC-ed stable. Once you ACK these (add/remove patches), we could
>> ask stable to include these patches.
> 
> Looks good.
> 
> Acked-by: Steve French <sfrench at us.ibm.com>

Here's the diffstat of the changes:

 cifs_unicode.h |    7 +++++++
 cifssmb.c      |    2 +-
 connect.c      |    6 +-----
 misc.c         |    5 +++--
 readdir.c      |    2 +-
 sess.c         |   44 +++++++++++++++++++++++---------------------
 6 files changed, 36 insertions(+), 30 deletions(-)


Thanks,

-- 
Suresh Jayaraman


More information about the linux-cifs-client mailing list