[linux-cifs-client] Re: [PATCH 4/4] cifs: flush data on any setattr

[Steve French]

On Thu, Mar 26, 2009 at 7:07 PM, Linus Torvalds
<torvalds at linux-foundation.org> wrote:
> On Thu, 26 Mar 2009, Jeff Layton wrote:

>> I suspect that there is another bug for the reporter that's consistently
>> causing a reconnect of the socket after the fchmod. That problem could
>> even be server-side (hard to know without a wire capture and/or some
>> debug logs).
>
> Sure. There probably is. But even if we were to fix that unrelated issue,
> you might still have totally random events that cause re-connects for
> non-buggy reasons (say, a real network problem), so regardless it's not
> correct to assume that reconnects cannot happen.
There is probably still more that could be done, e.g. to flush data to the
server more frequently in the background, that would help.

>> On the performance side, we can always go back and optimize the flush
>> out of some of setattr calls when we *know* that they won't cause a
>> problem, but the list of those cases is starting to look pretty small.
>
> Agreed. Especially as you end up having to flush at the close() anyway,
> and anybody who does some attribute change after writing dirty data is
> likely to close the file afterwards

OK.   I will merge the change to flush on all setattr into cifs-2.6.git



-- 
Thanks,

Steve