[linux-cifs-client] Re: [PATCH 4/4] cifs: flush data on any setattr

Steve French smfrench at gmail.com
Thu Mar 26 20:10:49 GMT 2009


On Thu, Mar 26, 2009 at 12:35 PM, Jeff Layton <jlayton at redhat.com> wrote:
> We already flush all the dirty pages for an inode before doing
> ATTR_SIZE and ATTR_MTIME changes. There's another problem though -- if
> we change the mode so that the file becomes read-only then we may not
> be able to write data to it after a reconnect.

Do we have any idea of how badly this would hurt performance?

Changing the mode or owner may be rare enough ... but I don't have any
data to prove that.

Changing the file's mode on the fly while writing could cause problems
for file systems other than cifs too, not sure we want to hurt
performance for a corner case of a bad application.  I don't this
posix specifies that chmod does an implied fsync




-- 
Thanks,

Steve


More information about the linux-cifs-client mailing list