[linux-cifs-client] Re: cifs: remove "sockopt" mount option

[Jeff Layton]

On Thu, 25 Jun 2009 17:42:43 -0500
Steve French <smfrench at gmail.com> wrote:

> Looking at patch
> http://git.samba.org/?p=jlayton/cifs.git;a=commit;h=1c1e39d7cd344ef662c958cfad5e1a0df804ac74
> 
> which would remove the "sockopt" mount option (which is currently
> unimplemented), I spent some time looking at the equivalent smb.conf
> mount option ("socket options") which smbfs and samba client and
> server use.  The explanation and examples of times it is useful to
> override socket options (e.g. for setting low delay) seem reasonable.
> It looks like it would be better to add parsing to allow setting these
> to allow those who need to do advanced tuning.
> 

Ok, but let's not just leave this stub option laying around. The time
to add a new option to the parser is when there's some code to back it
up and make it actually do something useful.

A) it's confusing since it doesn't actually work

B) it just bloats out the code for no good purpose

For the record, I'm also disappointed that the commented out asn1
function got merged today too. I'd have preferred to see that go in
when it actually becomes useful (and usable).

-- 
Jeff Layton <jlayton at redhat.com>