[linux-cifs-client] [PATCH] mount.cifs: properly check for mount being in fstab when running setuid root (try#3)

[Jeff Layton]

On Wed, 2009-07-22 at 11:42 -0500, Shirish Pargaonkar wrote:
> Jeff,
> 
> late comments... but as mentioned in Samba bugzilla bug 5118, it is
> confusing to use
> user (to allow user mounts) and user=<username> mount options in an
> entry in /etc/fstab.
> I do not see any other way but to allow/continue using them as they are.
> They are handled correctly, just that the same mount option getting
> used twice for
> different purposes can be confusing!

Agreed. The decision to use "user=" for specifying the username was not
a good one. I think smbfs used "username=", and I believe it was for
that reason.

Unfortunately, we're sort of stuck with it for the time being. We could
start transitioning away from it but we'll need to come up with a
replacement option name (maybe username=) and set it up as an alias for
user=. Then set it up so that user= generates a warning  at mount time
so that people can start moving their options over. Eventually we'd
deprecate that option altogether (make it cause the mount to error out).

That'll probably take some time since we'll have to phase it in
gradually, probably over a year or more.

-- 
Jeff Layton <jlayton at redhat.com>