[linux-cifs-client] lookup create with O_EXCL patch merged

Steve French smfrench at gmail.com
Wed Jul 8 21:58:27 GMT 2009


Now that it has been tested by Shirish, merged Jeff's patch into cifs-2.6.git

cifs: fix regression with O_EXCL creates and optimize away lookup

Signed-off-by: Jeff Layton <jlayton at redhat.com>
Tested-by: Shirish Pargaonkar <shirishp at gmail.com>
CC: Stable Kernel <stable at kernel.org>
---

diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
index a40054f..ff55fc6 100644
--- a/fs/cifs/dir.c
+++ b/fs/cifs/dir.c
@@ -643,6 +643,15 @@ cifs_lookup(struct inode *parent_dir_inode,
struct dentry *direntry,
 			}
 	}

+	/*
+	 * O_EXCL: optimize away the lookup, but don't hash the dentry. Let
+	 * the VFS handle the create.
+	 */
+	if (nd->flags & LOOKUP_EXCL) {
+		d_instantiate(direntry, NULL);
+		return 0;
+	}
+
 	/* can not grab the rename sem here since it would
 	deadlock in the cases (beginning of sys_rename itself)
 	in which we already have the sb rename sem */

-- 
Thanks,

Steve


More information about the linux-cifs-client mailing list