[linux-cifs-client] Re: [PATCH] cifs: remove dnotify thread code

[Jeff Layton]

On Thu, 8 Jan 2009 21:32:09 -0600
"Steve French" <smfrench at gmail.com> wrote:

> What worries me most about losing the ability to add directory change
> notification in the future (without putting the entry point back) the
> lack of directory change notification is quite visible to the user
> when an open directory object on the desktop (gnome or kde) does not
> automatically refresh within a few seconds as files are added on the
> remote system (or on another client).
> 
> The old cifs implementation was broken (partially implemented) but it
> was "dead code" so was harmless (it required configuring with
> CONFIG_CIFS_EXPERIMENTAL and turning on a run time flag in
> /proc/fs/cifs to enable it) but it might not have been too bad to
> finish the implementation.
> 

This patch doesn't remove any capability of the current code. It just
gets rid of this kthread that doesn't do anything useful. There's
nothing stopping us from putting it back later once we have working dir
notification, but until then it's just doing unnecessary wakeups.

-- 
Jeff Layton <jlayton at redhat.com>