[linux-cifs-client] Re: NULL deref cifs_unlink()

Dan Carpenter error27 at gmail.com
Wed Feb 25 14:49:50 GMT 2009


On 2/25/09, Steve French <smfrench at gmail.com> wrote:
> I think that this is ok (albeit not easy to read).
>
> dosattr != 0    when attrs == NULL
> so we won't go into the cifs_set_file_info call when attrs is null.
>

Yeah.  I see that now.  My mistake.

I don't think there is a need to patch it.  I was just testing my code
checker and it got it wrong and then I read it wrong too.  It's better
for me to patch the checker than to change the code.  ;)

regards,
dan carpenter


More information about the linux-cifs-client mailing list