[linux-cifs-client] Re: [PATCH 3/3] cifs: have cifs_create use POSIX create if it's available

[Steve French]

On Wed, Feb 11, 2009 at 7:08 AM, Jeff Layton <jlayton at redhat.com> wrote:

> This reduces the number of calls to the server when creating files, and
> also makes the force_create_mode option in samba work correctly.
>
> It also refactors some of the error handling in this function to
> reduce layers of indentation.
>
> This is the second attempt at this patch. The first patch had a
> bug in the open flag conversion routines and didn't try to enable
> O_DIRECT on direct I/O mounts.
>

This is great, but wondering if the posix create code should be split out to
a different function - calling out early from cifs_create to a new
posix_create (when the server supports posix extensions) to reduce the size
of this (now) 250+ line cifs_create function (as I had done in my earlier
start on posix_create last month).



-- 
Thanks,

Steve
-------------- next part --------------
HTML attachment scrubbed and removed