[linux-cifs-client] [PATCH] [CIFS] Prevent OOPs when mounting with remote prefixpath

[Igor Mammedov]

Patch with Jeff's suggestions is attached.

Jeff Layton wrote:
> On Wed, 04 Feb 2009 13:35:16 +0300
...
> 
> Maybe something like:
> 
>     cERROR(1, ("Path %s not accessable: %d", full_path, rc));
> 
> ...of course, you'd need to not kfree full_path until after this is
> printed but that's not too tough.
> 
> Won't this error also fire when trying to mount with an inaccessable
> prefixpath, even if DFS is involved? If so, then mentioning DFS in
> the error is probably going to be confusing for users/admins.
> 
> Actually, there's another problem too. If build_path_to_root ends up
> returning NULL, then we'll just skip this check. Shouldn't we return
> -ENOMEM or something at that point? It's probably better to fail the
> mount than to leave the client subject to a later oops...
> 

-- 

Best regards,

-------------------------
Igor Mammedov,
niallain "at" gmail.com




-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001--CIFS-Prevent-OOPs-when-mounting-with-remote-prefix.patch
Type: text/x-patch
Size: 3611 bytes
Desc: not available
Url : http://lists.samba.org/archive/linux-cifs-client/attachments/20090204/5c222999/0001--CIFS-Prevent-OOPs-when-mounting-with-remote-prefix.bin