[linux-cifs-client] [PATCH] slow-work: Fix build bug in the !CONFIG_MODULES case

Stephen Rothwell sfr at canb.auug.org.au
Tue Dec 1 00:30:04 MST 2009


Hi Ingo,

On Tue, 1 Dec 2009 07:56:05 +0100 Ingo Molnar <mingo at elte.hu> wrote:
>
> these slow-work changes have introduced a new !CONFIG_MODULES build bug 
> on x86 (and all other architectures i suspect):

Thanks for the heads up!

> From: Ingo Molnar <mingo at elte.hu>
> Date: Tue, 1 Dec 2009 07:47:52 +0100
> Subject: [PATCH] slow-work: Fix build bug in the !CONFIG_MODULES case
> 
> Commit 3bde31a ("SLOW_WORK: Allow a requeueable work item to sleep till
> the thread is needed") broke the !CONFIG_MODULES build by relying on
> variables that are only available (and only make sense) with module
> support enabled. Fix it.
> 
> Cc: David Howells <dhowells at redhat.com>
> Cc: Linus Torvalds <torvalds at linux-foundation.org>
> Cc: Andrew Morton <akpm at linux-foundation.org>
> Signed-off-by: Ingo Molnar <mingo at elte.hu>

I have applied this to linux-next for today, just so people don't waste
their time finding this breakage again.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/linux-cifs-client/attachments/20091201/81f3fe5f/attachment-0001.pgp>


More information about the linux-cifs-client mailing list