[linux-cifs-client] Re: [PATCH 00/12] cifs: fix string conversions from wire format to local charset (try #3)

[Steve French]

Have merged Jeff's fixes (minus the two which don't fix string conversions).

I removed the dead code in sessionsetup functions in connect.c (about
450 lines), except the 2 ntlmssp functions which I will rewrite
tonight or tomorrow, but there are some problems that the patch
testing uncovered:

1) readdir (findfirst level 257, in which strings are length delimited
rather than null terminated) doesn't seem to handle files which are
not null terminated (causing extra characters to appear at the end of
some file names)

2) In testing of various types of links (prior to removing the last
few lines from readlink, I had already removed most of readlink an
hour ago, the part that contained string conversions)  I found out
that we don't handle a new type of link that Vista introduces (NTFS
symlinks) - NTFS symlinks look like directory reparse points (like
Junctions e.g., but junctions my testing shows, do work fine), but
return STATUS_STOPPED_ON_SYMLINK  when you do findfirst on them.  This
shows up a bug in FindFirst (initiate_cifs_search does not check for
file->invalidHandle before doing SMB FindNext in all cases).


-- 
Thanks,

Steve