[linux-cifs-client] Re: [PATCH 11/12] cifs: remove legacy NTLMSSP code

[Steve French]

Building and testing the remaining changes now.  Turning out to be easy.

On Thu, Apr 30, 2009 at 6:42 AM, Jeff Layton <jlayton at redhat.com> wrote:
> This code is pretty much unmaintained at the moment. It's only used when
> the Experimental flag is set to a certain value.

commit 20418acd6874792359b42c12d159f42f17593f34
Author: Steve French <sfrench at us.ibm.com>
Date:   Thu Apr 30 16:13:32 2009 +0000

    [CIFS] Remove older session setup implementation

    Two years ago, when the session setup code in cifs was rewritten and moved
    to fs/cifs/sess.c, we were asked to keep the old code for a release or so
    (which could be reenabled at runtime) since it was such a large change and
    because the asn (SPNEGO) and NTLMSSP code was not rewritten and needed to
    be. This was useful to avoid regressions, but is long overdue to be removed.
    Now that the Kerberos (asn/spnego) code is working in fs/cifs/sess.c,
    and the NTLMSSP code moved (NTLMSSP blob setup be rewritten with the
    next patch in this series) quite a bit of dead code from fs/cifs/connect.c
    now can be removed.

    This old code should have been removed last year, but the earlier krb5
    patches did not move/remove the NTLMSSP code which we had asked to
    be done first.  Since no one else volunteered, I am doing it now.

    It is extremely important that we continue to examine the documentation
    for this area, to make sure our code continues to be uptodate with
    changes since Windows 2003.

    Signed-off-by: Steve French <sfrench at us.ibm.com>



-- 
Thanks,

Steve