[linux-cifs-client] Re: [PATCH 00/12] cifs: fix string conversions from wire format to local charset (try #3)

[Steve French]

On Thu, Apr 30, 2009 at 9:56 AM, Jeff Layton <jlayton at redhat.com> wrote:
> Don't forget about the duplicate code in CIFSSesSetup (or whatever the
> studly caps are for it). That adds another few hundred lines or so.
> Removing the NTLMSSP code would take a 1000 line chunk out of cifs, to
> which I say "hurrah!".

We had discussed simply throwing away all of CIFSSesSetup and
a good chunk of now unneeded code in cifs_setup_session, and
only salvaging/porting/rewriting the two NTLMSSP functions.

Do we want to port anything out of CIFSSesSetup?  It
was just the old NTLM code, which can be thrown away not that
the fs/cifs/sess.c code is stable.  Is there any unique function in
that that is not in fs/cifs/sess.c already?




-- 
Thanks,

Steve