[linux-cifs-client] Re: [PATCH 00/12] cifs: fix string conversions from wire format to local charset (try #3)

[Steve French]

On Wed, Apr 29, 2009 at 3:24 PM, Jeff Layton <jlayton at redhat.com> wrote:
> This is the third set of patches for this problem. The main changes
> from the last set are some minor renames of some of the functions,
> some fleshing out of comments and a fix for an endianness problem
> that the earlier set introduced to CIFSTCon.
>
> This patchset is intended to fix the string conversions in cifs that
> convert strings from "wire-format" (little-endian UTF-16) to whatever
> character set is in use on the client.
>
> This patch is built upon work by Suresh Jayaraman. This shouldn't be

Good job on these (and also to Suresh and others at Novell for tracking
some of the initial problems and proposing the first set of changes).
Via IRC and email I made various cosmetic suggestions to the patch
(and one correction) which Jeff incorporated in the latest patches.   As
we discussed via IRC, all but patches 9 and 11 (which are not fixes to
string conversions) can go in the tree as soon as we get an ACK from Suresh
(or unless we get a NACK from mailing list feedback).

I don't know whether this should go in stable or not.  It is rather large
and would have trouble merging if we went back before 2.6.29 but
I don't object given the possible effect of an incorrect conversion
overrun.


-- 
Thanks,

Steve