[linux-cifs-client] Re: [PATCH 08/10] cifs: remove cifs_readlink and CIFSSMBQueryReparseLinkInfo

Jeff Layton jlayton at redhat.com
Wed Apr 29 14:54:34 GMT 2009


On Wed, 29 Apr 2009 09:40:42 -0500
Steve French <smfrench at gmail.com> wrote:

> I am just trying to figure out what happens when we hit this - if we
> have a bug, lets fix it.  I haven't tried this in a while.
> 

Hit it how? This code is dead. It's not reachable from any current
codepath. I'm not even sure how it was intended to be used in the first
place.

If you want to fix it, then that's fine, but I don't really want to
work on it at this point in time. It's also not appropriate to do that
in the context of this patchset which is about fixing the unicode
string handling problems. I suggest that we just remove this code for
now, and then you can put it back later when these functions are fixed,
tested and actually work.

-- 
Jeff Layton <jlayton at redhat.com>


More information about the linux-cifs-client mailing list